KomuSolutions/WANessa
Archived
4
0
Fork 0
Code Issues 26 Pull Requests 1 Actions Projects 1 Releases Activity

Improve README #24

Merged
hendrik merged 9 commits from README-fix into main 2024-02-15 14:56:25 +01:00
Conversation 20 Commits 9 Files Changed 2 +2 -1
lukas commented 2024-02-14 18:31:17 +01:00
Owner
Copy Link

relates to #23

relates to #23
lukas added the
Kind/Documentation
 label 2024-02-14 18:31:17 +01:00
lukas added 4 commits 2024-02-14 18:31:18 +01:00
doubled the amount of A
All checks were successful
continuous-integration/drone/push Build is passing
Details
9b57da84c3 
A is an important part of every healthy breakfast, increased it so that everyone may get enough A. Relates to #23
fix v2
All checks were successful
continuous-integration/drone/push Build is passing
Details
2cca88d709
actually sane readme
All checks were successful
continuous-integration/drone/push Build is passing
Details
c751a3240e 
#23
add some A's
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
ae6539e456
lukas commented 2024-02-14 18:32:01 +01:00
Author
Owner
Copy Link

May I squash @leon @hendrik?

May I squash @leon @hendrik?
leon requested review from leon 2024-02-14 18:32:32 +01:00
leon commented 2024-02-14 18:32:49 +01:00
Owner
Copy Link

Fixes #23

Fixes #23
leon approved these changes 2024-02-14 18:33:30 +01:00
Dismissed
leon left a comment
Owner

I like the reference to the superior version of the README 👍

I like the reference to the superior version of the README 👍
lukas was assigned by leon 2024-02-14 18:33:43 +01:00
lukas commented 2024-02-14 18:34:38 +01:00
Author
Owner
Copy Link

Then we just need the master of degeneracy to approve, at last.

Then we just need the master of degeneracy to approve, at last.
lukas requested review from hendrik 2024-02-14 18:34:48 +01:00
lukas added 1 commit 2024-02-14 18:37:08 +01:00
some final improvements
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
89b62242bf
lukas dismissed leon’s review 2024-02-14 18:37:08 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

lukas added 1 commit 2024-02-14 18:38:39 +01:00
tidying up
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
cd95c46131
leon requested changes 2024-02-14 18:38:55 +01:00
leon left a comment
Owner

The reference at the end is not valid REGEX anymore

The reference at the end is not valid REGEX anymore
lukas commented 2024-02-14 18:39:23 +01:00
Author
Owner
Copy Link

but it's a lot more A's

but it's a lot more A's
leon commented 2024-02-14 18:39:58 +01:00
Owner
Copy Link

No, it is just One A with a dot plus 1024 2s

No, it is just One A with a dot plus 1024 2s
lukas added 1 commit 2024-02-15 07:26:50 +01:00
revert to regex-compliant readme
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
3c6be42b9e
lukas commented 2024-02-15 07:26:58 +01:00
Author
Owner
Copy Link

reverted the change

reverted the change
leon approved these changes 2024-02-15 14:35:30 +01:00
leon left a comment
Owner

i can finally die now

i can finally die now
hendrik approved these changes 2024-02-15 14:46:37 +01:00
hendrik left a comment
Owner

"Dateidiff unterdrückt, weil mindestens eine Zeile zu lang ist"
Ich unterstütze das von ganzem Herzen

"Dateidiff unterdrückt, weil mindestens eine Zeile zu lang ist" Ich unterstütze das von ganzem Herzen
lukas commented 2024-02-15 14:47:16 +01:00
Author
Owner
Copy Link

Yay! Dann müssen wir jetzt nur noch die CI/CD fixen

Yay! Dann müssen wir jetzt nur noch die CI/CD fixen
lukas commented 2024-02-15 14:47:45 +01:00
Author
Owner
Copy Link

oder... ich schalte meinen runner aus und leon macht seinen weider an. Deal @leon?

oder... ich schalte meinen runner aus und leon macht seinen weider an. Deal @leon?
leon commented 2024-02-15 14:49:11 +01:00
Owner
Copy Link

You could just merge main into this branch, getting the ci/cd workarounds fixes

You could just merge main into this branch, getting the ci/cd ~~workarounds~~ fixes
lukas commented 2024-02-15 14:50:01 +01:00
Author
Owner
Copy Link

wir haben die doch noch garnciht gemerged, oder?

wir haben die doch noch garnciht gemerged, oder?
lukas added 1 commit 2024-02-15 14:51:24 +01:00
Merge branch 'main' into README-fix
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
475ac447d6
leon commented 2024-02-15 14:51:57 +01:00
Owner
Copy Link

oh yep, forgot that #27 was not merged yet

oh yep, forgot that #27 was not merged yet
lukas commented 2024-02-15 14:53:30 +01:00
Author
Owner
Copy Link

Sorry, was a UI issue it seems. I cleared the messages to escape confusion

Sorry, was a UI issue it seems. I cleared the messages to escape confusion
lukas added 1 commit 2024-02-15 14:53:46 +01:00
Merge branch 'main' into README-fix
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
a67e1439eb
lukas commented 2024-02-15 14:54:23 +01:00
Author
Owner
Copy Link

tf, you what now?????
https://drone.libre.moe/KomuSolutions/WANessa/353/3/1

tf, you what now????? https://drone.libre.moe/KomuSolutions/WANessa/353/3/1
lukas commented 2024-02-15 14:55:02 +01:00
Author
Owner
Copy Link

fixed it :) (by restarting, which should not have worked but let's not worry about it)

fixed it :) (by restarting, which should not have worked but let's not worry about it)
leon commented 2024-02-15 14:55:26 +01:00
Owner
Copy Link

tf, you what now?????
https://drone.libre.moe/KomuSolutions/WANessa/353/3/1

Just retry the pipeline once or twice.

> tf, you what now????? > https://drone.libre.moe/KomuSolutions/WANessa/353/3/1 Just retry the pipeline once or twice.
leon commented 2024-02-15 14:56:04 +01:00
Owner
Copy Link

fixed it :) (by restarting, which should not have worked but let's not worry about it)

It happens from time to time. Restarting once or twice always fixed it.

> fixed it :) (by restarting, which should not have worked but let's not worry about it) It happens from time to time. Restarting once or twice always fixed it.
hendrik merged commit 8ebe2d8aff into main 2024-02-15 14:56:25 +01:00
hendrik deleted branch README-fix 2024-02-15 14:56:25 +01:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
leon
hendrik
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Command
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Idea
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Policy Enforcement
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Documentation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees lukas
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KomuSolutions/WANessa#24
No description provided.
Delete Branch "README-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?