KomuSolutions/WANessa
Archived
4
0
Fork 0
Code Issues 26 Pull Requests 1 Actions Projects 1 Releases Activity

duplicate stupid workarounds #27

Merged
lukas merged 1 commits from drone-amd64-fix into main 2024-02-15 14:53:37 +01:00
Conversation 12 Commits 1 Files Changed 1 +12
lukas commented 2024-02-15 08:08:26 +01:00
Owner
Copy Link

CI builds on my amd64 server running RL9 also exhibit the same DNS-issues observed on arm64 Hetzner servers (see KomuSolutions/igot99issues#16).
This PR also applies the stupid but working fix for arm64 to amd64 as well.

CI builds on my `amd64` server running RL9 also exhibit the same DNS-issues observed on `arm64` Hetzner servers (see https://git.libre.moe/KomuSolutions/igot99issues/issues/16). This PR also applies the ~~stupid but~~ working fix for `arm64` to `amd64` as well.
lukas added 1 commit 2024-02-15 08:08:26 +01:00
duplicate stupid workarounds
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
b645c1cdaa
lukas requested review from leon 2024-02-15 08:09:57 +01:00
lukas commented 2024-02-15 08:39:14 +01:00
Author
Owner
Copy Link

but hold up, wieso geht die pipeline bei WANessa nicht, aber in meinem test repo schon.

Like, beide nutzen den gleichen command: https://git.libre.moe/KomuSolutions/WANessa/src/branch/README-fix/.drone.yml#L27 und https://git.libre.moe/lukas/test/src/branch/master/.drone.yml#L13, und das im gleichen image

but hold up, wieso geht die pipeline bei WANessa [nicht](https://drone.libre.moe/KomuSolutions/WANessa/348/1/4), aber in meinem test repo [schon](https://drone.libre.moe/lukas/test/16/1/2). Like, beide nutzen den gleichen command: https://git.libre.moe/KomuSolutions/WANessa/src/branch/README-fix/.drone.yml#L27 und https://git.libre.moe/lukas/test/src/branch/master/.drone.yml#L13, und das im gleichen image
lukas commented 2024-02-15 08:44:06 +01:00
Author
Owner
Copy Link

like in lukas/test geht es sogar mit beiden, arm64 und amd64. Das ist einfach erfolgreich. (Verweis auf KomuSolutions/igot99issues#16 für später)

like in [lukas/test](https://git.libre.moe/lukas/test/src/branch/master/.drone.yml) geht es sogar mit beiden, `arm64` und `amd64`. Das ist einfach [erfolgreich](https://drone.libre.moe/lukas/test/19/2/2). (Verweis auf https://git.libre.moe/KomuSolutions/igot99issues/issues/16 für später)
lukas commented 2024-02-15 08:44:36 +01:00
Author
Owner
Copy Link

@leon ich brauche unbedingt deinen Input, was übersehe ich hier? (Und mach deinen amd64 runner kurz aus, sonst wird das confusing)

@leon ich brauche unbedingt deinen Input, was übersehe ich hier? (Und mach deinen `amd64` runner kurz aus, sonst wird das confusing)
leon commented 2024-02-15 13:50:51 +01:00
Owner
Copy Link

@leon ich brauche unbedingt deinen Input, was übersehe ich hier? (Und mach deinen amd64 runner kurz aus, sonst wird das confusing)

My amd64 runner is hosted on my Desktop PC, so it was offline during your tests. I have now deactivated it completely.

> @leon ich brauche unbedingt deinen Input, was übersehe ich hier? (Und mach deinen `amd64` runner kurz aus, sonst wird das confusing) My amd64 runner is hosted on my Desktop PC, so it was offline during your tests. I have now deactivated it completely.
lukas commented 2024-02-15 13:56:32 +01:00
Author
Owner
Copy Link

for the git record: the issues/comments were created with that already in mind

for the git record: the issues/comments were created with that already in mind
leon commented 2024-02-15 14:12:04 +01:00
Owner
Copy Link

like in lukas/test geht es sogar mit beiden, arm64 und amd64. Das ist einfach erfolgreich. (Verweis auf KomuSolutions/igot99issues#16 für später)

Perhaps it just does not like me because it does not work, when I try it:
https://drone.libre.moe/leon/CI-test

> like in [lukas/test](https://git.libre.moe/lukas/test/src/branch/master/.drone.yml) geht es sogar mit beiden, `arm64` und `amd64`. Das ist einfach [erfolgreich](https://drone.libre.moe/lukas/test/19/2/2). (Verweis auf https://git.libre.moe/KomuSolutions/igot99issues/issues/16 für später) Perhaps it just does not like me because it does not work, when I try it: https://drone.libre.moe/leon/CI-test
lukas commented 2024-02-15 14:23:41 +01:00
Author
Owner
Copy Link

It does! Like, here is your drone.yml and here is my drone.yml. I only removed the cargo build as there is nothing to build and therefore fail, but the downloading part should be 1:1, yet your build is failing and mine isn't.

It does! Like, here is your [drone.yml](https://git.libre.moe/leon/CI-test/src/branch/main/.drone.yml) and here is my [drone.yml](https://git.libre.moe/lukas/test/src/branch/master/.drone.yml). I only removed the `cargo build` as there is nothing to build and therefore fail, but the downloading part should be 1:1, yet your build is [failing](https://drone.libre.moe/leon/CI-test/2/2/2) and mine [isn't](https://drone.libre.moe/lukas/test/22/2/2).
lukas commented 2024-02-15 14:24:20 +01:00
Author
Owner
Copy Link

can you .. like, maybe rebuild? just to be sure

can you .. like, maybe rebuild? just to be sure
leon commented 2024-02-15 14:34:17 +01:00
Owner
Copy Link

can you .. like, maybe rebuild? just to be sure

yep, failed again...

> can you .. like, maybe rebuild? just to be sure yep, failed again...
lukas commented 2024-02-15 14:35:21 +01:00
Author
Owner
Copy Link

are we sure that it really is using the same runner?

are we sure that it really is using the same runner?
leon commented 2024-02-15 14:36:48 +01:00
Owner
Copy Link

are we sure that it really is using the same runner?

At least the amd64 should be the same, since my runner is not active anymore.

> are we sure that it really is using the same runner? At least the amd64 should be the same, since my runner is not active anymore.
lukas commented 2024-02-15 14:50:52 +01:00
Author
Owner
Copy Link

welp, shall we merge then? #24 is waiting

welp, shall we merge then? #24 is waiting
leon approved these changes 2024-02-15 14:53:15 +01:00
leon left a comment
Owner

you may merge it

you may merge it
lukas merged commit db1a21f5b3 into main 2024-02-15 14:53:37 +01:00
lukas deleted branch drone-amd64-fix 2024-02-15 14:53:37 +01:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
leon
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Command

   
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Idea

   
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Policy Enforcement
  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Command
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Idea
Kind/Security
Kind/Testing
Policy Enforcement
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: KomuSolutions/WANessa#27
No description provided.
Delete Branch "drone-amd64-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?