KomuSolutions/szuru
2
0
Fork 0
Code Issues Actions Packages Releases Wiki Activity
2.1
szuru/client/html/fav.tpl

16 lines
465 B
Smarty
Raw Permalink Normal View History

client/comments: add comment list view for post
2016-06-11 17:41:28 +02:00
<% if (ctx.canFavorite) { %>
<% if (ctx.ownFavorite) { %>
client/general: add empty href for link buttons In e464e69 I removed href='#' but I noticed that it broke some things. Readding href serves two purposes: - it makes links reachable with Tab key - it makes links clickable with Enter key The alternative to this approach was to introduce [tabindex] and [role] attributes. But not only using tabindex=0 with <a/> is questionable, it'd require adding a keyboard handler that'd intercept space and return key presses and simulated link clicks. Since it's best to leave this kind of thing to the native UI, I went with readding hrefs instead. I believe that hash hrefs, even though being a common practice, are silly, so I decided to settle down with empty hrefs. As a bonus, I added a snippet that prevents middle mouse clicks from opening such links/buttons in new tabs, which was the motivation for e464e69.
2016-08-22 01:25:10 +02:00
<a href class='remove-favorite'>
client/comments: add comment list view for post
2016-06-11 17:41:28 +02:00
<i class='fa fa-heart'></i>
<% } else { %>
client/general: add empty href for link buttons In e464e69 I removed href='#' but I noticed that it broke some things. Readding href serves two purposes: - it makes links reachable with Tab key - it makes links clickable with Enter key The alternative to this approach was to introduce [tabindex] and [role] attributes. But not only using tabindex=0 with <a/> is questionable, it'd require adding a keyboard handler that'd intercept space and return key presses and simulated link clicks. Since it's best to leave this kind of thing to the native UI, I went with readding hrefs instead. I believe that hash hrefs, even though being a common practice, are silly, so I decided to settle down with empty hrefs. As a bonus, I added a snippet that prevents middle mouse clicks from opening such links/buttons in new tabs, which was the motivation for e464e69.
2016-08-22 01:25:10 +02:00
<a href class='add-favorite'>
client/comments: add comment list view for post
2016-06-11 17:41:28 +02:00
<i class='fa fa-heart-o'></i>
<% } %>
<% } else { %>
<a class='add-favorite inactive'>
<i class='fa fa-heart-o'></i>
<% } %>
<span class='vim-nav-hint'>add to favorites</span>
</a>
client/views: escape HTML This lets client use < > in tag names.
2016-06-23 11:41:52 +02:00
<span class='value'><%- ctx.favoriteCount %></span>
Reference in New Issue Copy Permalink