d5e197e6ea
Ine464e69I removed href='#' but I noticed that it broke some things. Readding href serves two purposes: - it makes links reachable with Tab key - it makes links clickable with Enter key The alternative to this approach was to introduce [tabindex] and [role] attributes. But not only using tabindex=0 with <a/> is questionable, it'd require adding a keyboard handler that'd intercept space and return key presses and simulated link clicks. Since it's best to leave this kind of thing to the native UI, I went with readding hrefs instead. I believe that hash hrefs, even though being a common practice, are silly, so I decided to settle down with empty hrefs. As a bonus, I added a snippet that prevents middle mouse clicks from opening such links/buttons in new tabs, which was the motivation fore464e69.
16 lines
465 B
Smarty
16 lines
465 B
Smarty
<% if (ctx.canFavorite) { %>
|
|
<% if (ctx.ownFavorite) { %>
|
|
<a href class='remove-favorite'>
|
|
<i class='fa fa-heart'></i>
|
|
<% } else { %>
|
|
<a href class='add-favorite'>
|
|
<i class='fa fa-heart-o'></i>
|
|
<% } %>
|
|
<% } else { %>
|
|
<a class='add-favorite inactive'>
|
|
<i class='fa fa-heart-o'></i>
|
|
<% } %>
|
|
<span class='vim-nav-hint'>add to favorites</span>
|
|
</a>
|
|
<span class='value'><%- ctx.favoriteCount %></span>
|