Leon Wilzer leon
  • I can use Markdown

  • Joined on 2022-03-06
230 contributions in the last 12 months
AprMayJunJulAugSepOctNovDecJanFebMarMonWedFri
Less
More
leon commented on pull request KomuSolutions/WANessa#26 2024-02-15 18:34:43 +01:00
Logging

logging/src/lib.rs:46 and logging/src/lib.rs:48 will panic if an IO error occurs. Maybe consider to not panic and print another error to the console, informing about the writing problems, rather than crashing the program as logging is not a crucial feature for the program's functioning

leon commented on pull request KomuSolutions/WANessa#26 2024-02-15 18:34:43 +01:00
Logging

logging/src/lib.rs:102 will panic if any code requests write-lock on config::CONFIG and then panics. Consider using Arc to ensure immutability and accessibility to the configuration from any thread at any time

leon commented on pull request KomuSolutions/WANessa#26 2024-02-15 18:26:43 +01:00
Logging
leon commented on pull request KomuSolutions/WANessa#26 2024-02-15 18:02:04 +01:00
Logging
leon commented on pull request KomuSolutions/WANessa#26 2024-02-15 18:01:53 +01:00
Logging

I suggest some stability changes:

LogVerbosity doesn't specify values, but logging/src/lib.rs:75 assumes order -> Accidental reordering of the enum would lead to errors

leon opened issue KomuSolutions/WANessa#28 2024-02-15 16:50:33 +01:00
CI (Re-)Consideration
leon commented on issue KomuSolutions/igot99issues#19 2024-02-15 15:05:58 +01:00
Organization setting borked

Ich würde eigentlich auch lieber in Zukunft auf Gitea's eigenes CI/CD setzten, da das besser intigriert ist - wenn es denn nur vernünftig arm supporten würde.

Ja, wobei ich finde, dass…

leon pushed to Logging at KomuSolutions/WANessa 2024-02-15 15:03:28 +01:00
2a2a2fd805 Merge branch 'main' into Logging
8ebe2d8aff Merge pull request 'Improve README' () from README-fix into main
a67e1439eb Merge branch 'main' into README-fix
db1a21f5b3 Merge pull request 'duplicate stupid workarounds' () from drone-amd64-fix into main
475ac447d6 Merge branch 'main' into README-fix
Compare 13 commits »
leon commented on pull request KomuSolutions/WANessa#24 2024-02-15 14:56:04 +01:00
Improve README

fixed it :) (by restarting, which should not have worked but let's not worry about it)

It happens from time to time. Restarting once or twice always fixed it.

leon commented on pull request KomuSolutions/WANessa#24 2024-02-15 14:55:26 +01:00
Improve README

tf, you what now????? https://drone.libre.moe/KomuSolutions/WANessa/353/3/1

Just retry the pipeline once or twice.

leon approved KomuSolutions/WANessa#27 2024-02-15 14:53:15 +01:00
duplicate stupid workarounds

you may merge it

leon commented on pull request KomuSolutions/WANessa#24 2024-02-15 14:51:57 +01:00
Improve README

oh yep, forgot that #27 was not merged yet

leon commented on pull request KomuSolutions/WANessa#24 2024-02-15 14:49:11 +01:00
Improve README

You could just merge main into this branch, getting the ci/cd workarounds fixes

leon commented on issue KomuSolutions/igot99issues#19 2024-02-15 14:45:14 +01:00
Organization setting borked

Okay ich verstehe das aber irgendwie nicht. Es soll drone abloesen, hat aber noch nicht die gleichen Features und man kann darauf source code hosten? Ist das dann nicht basically gitlab? Ich…

leon commented on pull request KomuSolutions/WANessa#27 2024-02-15 14:36:48 +01:00
duplicate stupid workarounds

are we sure that it really is using the same runner?

At least the amd64 should be the same, since my runner is not active anymore.

leon approved KomuSolutions/WANessa#24 2024-02-15 14:35:30 +01:00
Improve README

i can finally die now

leon commented on pull request KomuSolutions/WANessa#27 2024-02-15 14:34:17 +01:00
duplicate stupid workarounds

can you .. like, maybe rebuild? just to be sure

yep, failed again...

leon commented on issue KomuSolutions/WANessa#9 2024-02-15 14:15:48 +01:00
Meme Templator

Perhaps we could also permanently save it as a toml, yaml or similar so that hashing and reusing already created memes is easier and perhaps user could export a higher quality PNG, which may be…

leon commented on pull request KomuSolutions/WANessa#27 2024-02-15 14:12:04 +01:00
duplicate stupid workarounds

like in lukas/test geht es sogar mit beiden, arm64 und amd64. Das ist einfach [erfolgreich](https://drone.libre.moe/lukas/test…